tweak: warn if RPC storage connection is unidentified

[marcospb19-cw]

PR Type

enhancement

---

Description

• Added a warning log in PostgresExternalRpcStorage::new to notify if the RPC storage connection URL does not contain the ?app=NAME query parameter.
• Imported the not utility function to facilitate the new warning condition.

---

Changes walkthrough 📝

	Relevant files
Enhancement	postgres_external_rpc.rs Add warning for unidentified RPC storage connection URL    src/eth/storage/postgres_external_rpc/postgres_external_rpc.rs Added a warning log if the RPC storage connection URL does not contain a specific query parameter. Imported a new utility function not. +5/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit f0fd4ab)

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Logging Enhancement The warning log added in PostgresExternalRpcStorage::new should include the reason for the warning in a structured field, such as reason. This will make it easier to filter and analyze logs. Initialization Logging The initialization of PostgresExternalRpcStorage should log all relevant configurations, not just the URL. This includes connection settings and other critical parameters.

[github-actions]

Persistent review updated to latest commit f0fd4ab

[github-actions]

PR Code Suggestions ✨

Latest suggestions up to f0fd4ab

Category	Suggestion	Score
Readability	Replace the not function with the ! operator for negation to improve readability The not function usage is unconventional and might be confusing. Consider using the ! operator for negation to improve readability. src/eth/storage/postgres_external_rpc/postgres_external_rpc.rs [42-44] -if not(config.url.contains('?')) { +if !config.url.contains('?') { tracing::warn!(url = config.url, "url isn't identified with '?app=NAME' query parameter"); } Suggestion importance[1-10]: 9 Why: The suggestion correctly identifies that using the ! operator for negation is more conventional and improves readability in Rust. The existing code using not is unconventional and might confuse readers.	9

---

Previous suggestions

Suggestions up to commit f0fd4ab

Category	Suggestion	Score
Possible bug	Replace the not function with the ! operator for negation The not function is not a standard Rust function for negation. Instead, use the ! operator to negate the condition. src/eth/storage/postgres_external_rpc/postgres_external_rpc.rs [42-44] -if not(config.url.contains('?')) { +if !config.url.contains('?') { tracing::warn!(url = config.url, "url isn't identified with '?app=NAME' query parameter"); } Suggestion importance[1-10]: 10 Why: The not function is not a standard Rust function for negation, and using the ! operator is the correct approach. This suggestion addresses a potential bug in the code.	10