fix: only insert historical values if changed

[dinhani-cw]

PR Type

Bug fix

---

Description

• Modified the zadd command in RedisPermanentStorage to use the NX option, ensuring that only new elements are added to the sorted set.
• Replaced the direct zadd call with a custom Redis command using redis::cmd to incorporate the NX option.

---

Changes walkthrough 📝

	Relevant files
Bug fix	redis_permanent.rs Ensure historical values are only inserted if changed in Redis src/eth/storage/redis/redis_permanent.rs Modified the zadd command to use the NX option to ensure only new elements are added. Replaced the direct zadd call with a custom Redis command using redis::cmd. +4/-4

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Possible Bug The cmd.exec(&mut conn) call on line 140 should be checked for proper error handling. Ensure that the command execution is correctly monitored and logged. Logging Improvement The error logging on line 142 should include the key and value as tracing fields for better context.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Use cmd.query(&mut conn) instead of cmd.exec(&mut conn) for better error handling and type safety Instead of using cmd.exec(&mut conn), consider using cmd.query(&mut conn) which returns a Result and can provide better error handling and type safety. src/eth/storage/redis/redis_permanent.rs [140] -let zadd: RedisVoid = cmd.exec(&mut conn); +let zadd: Result<RedisVoid, redis::RedisError> = cmd.query(&mut conn); Suggestion importance[1-10]: 9 Why: This suggestion improves error handling and type safety, which are crucial aspects in a storage system. Using cmd.query(&mut conn) returns a Result, making the code more robust and easier to debug.	9
Maintainability	Extract the ZADD command creation into a separate function for better readability and maintainability To improve readability and maintainability, consider extracting the ZADD command creation into a separate function. src/eth/storage/redis/redis_permanent.rs [137-138] -let mut cmd = redis::cmd("ZADD"); -cmd.arg(key).arg("NX").arg(score).arg(value); +fn create_zadd_command(key: &str, score: f64, value: &str) -> redis::Cmd { + let mut cmd = redis::cmd("ZADD"); + cmd.arg(key).arg("NX").arg(score).arg(value); + cmd +} +let cmd = create_zadd_command(key, score, value); + Suggestion importance[1-10]: 7 Why: This suggestion enhances code readability and maintainability by encapsulating the ZADD command creation in a separate function. This makes the main logic cleaner and easier to understand, though it is a minor improvement.	7