Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable tls for opentelemetry grpc #1081

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: enable tls for opentelemetry grpc #1081

merged 1 commit into from
Jun 12, 2024

Conversation

dinhani-cw
Copy link
Contributor

No description provided.

@dinhani-cw dinhani-cw requested a review from a team as a code owner June 12, 2024 22:57
@dinhani-cw dinhani-cw enabled auto-merge (squash) June 12, 2024 22:57
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]

1

🧪 Relevant tests

No

🔒 Security concerns

No

⚡ Key issues to review

None

Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Best practice
Specify exact versions for the tls and tls-roots features to avoid potential breaking changes

Consider specifying the exact versions of the tls and tls-roots features if they are
available. This can help in ensuring that the dependencies do not introduce breaking
changes unexpectedly if they are updated.

Cargo.toml [87]

-opentelemetry-otlp = { version = "=0.16.0", features = ["http-proto", "reqwest-client", "reqwest-rustls", "tls", "tls-roots"] }
+opentelemetry-otlp = { version = "=0.16.0", features = ["http-proto", "reqwest-client", "reqwest-rustls", "tls=<specific-version>", "tls-roots=<specific-version>"] }
 
Suggestion importance[1-10]: 7

Why: Specifying exact versions for features like tls and tls-roots can help prevent unexpected breaking changes due to updates. This is a good practice for maintaining stability, though it is not a critical issue.

7

@dinhani-cw dinhani-cw merged commit fe94ba2 into main Jun 12, 2024
24 checks passed
@dinhani-cw dinhani-cw deleted the tracing-tls branch June 12, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant