Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): ignore postgres tests #1069

Merged
merged 1 commit into from
Jun 11, 2024
Merged

refactor(ci): ignore postgres tests #1069

merged 1 commit into from
Jun 11, 2024

Conversation

mayconamaroCW
Copy link
Contributor

@mayconamaroCW mayconamaroCW commented Jun 11, 2024

We'll no longer support Postgres, this PR makes CI faster by not running Postgres's tests

@mayconamaroCW mayconamaroCW requested a review from a team as a code owner June 11, 2024 18:41
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]

2

🧪 Relevant tests

No

🔒 Security concerns

No

⚡ Key issues to review

Ignored Test:
The test parse_bytecode_slots in src/eth/primitives/bytecode.rs has been marked as ignored. Ensure that this is intentional and consider documenting the reason for ignoring this test.

Removed Workflow:
The entire GitHub Actions workflow for Postgres tests (e2e-contracts-postgres.yml) has been removed. Confirm that this aligns with the team's strategy for CI/CD, especially regarding database integration testing.

Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Maintainability
Add a reason for ignoring the test to improve clarity and maintainability

Consider adding a reason for ignoring the test parse_bytecode_slots using the ignore
attribute to clarify the context or conditions under which this test should be skipped.
This is helpful for maintaining the test suite and understanding the test coverage.

src/eth/primitives/bytecode.rs [99]

-#[ignore]
+#[ignore = "Reason why this test is ignored"]
 
Suggestion importance[1-10]: 8

Why: Adding a reason for ignoring the test improves the maintainability and clarity of the test suite, helping future developers understand why the test is skipped. This is a good practice for maintaining comprehensive test coverage.

8

@mayconamaroCW mayconamaroCW enabled auto-merge (squash) June 11, 2024 18:46
@mayconamaroCW mayconamaroCW merged commit c29b13b into main Jun 11, 2024
25 checks passed
@mayconamaroCW mayconamaroCW deleted the ci/ignore-postgres branch June 11, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant