Revert "lint: warn panics, expects and unwraps (#1543)" (#1545)

This reverts commit 6e25cc3.

.clippy.toml

@@ -1,3 +1 @@
-disallowed-names = ["lock"]
-allow-unwrap-in-tests = true
-allow-expect-in-tests = true
+disallowed-names = ["lock"]

.github/workflows/lint-check.yml

@@ -27,22 +27,12 @@ on:
 
 jobs:
   run_lint:
+    name: Lint and Style checks
     runs-on: ubuntu-latest
     timeout-minutes: 25
 
-    strategy:
-      fail-fast: false
-      matrix:
-        include: 
-          - name: Lint and Style checks
-            arguments: "-D warnings -A clippy::unwrap_used -A clippy::expect_used -A clippy::panic"
-          - name: Lint with unwrap expect panic
-            arguments: "-D warnings"
-
-    name: ${{ matrix.name }}
-
     concurrency:
-      group: ${{ github.workflow }}-${{ matrix.name }}-${{ github.ref || github.run_id }}
+      group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
       cancel-in-progress: true
 
     steps:
@@ -69,7 +59,7 @@ jobs:
         uses: extractions/setup-just@v2
 
       - name: Just lint-check
-        run: just lint-check -2024-02-29 "${{ matrix.arguments }}"
+        run: just lint-check -2024-02-29
 
   e2e_lint:
     name: E2E Lint

.github/workflows/merge-gatekeeper.yml

@@ -20,4 +20,4 @@ jobs:
           self: Merge Gatekeeper
           interval: 5
           timeout: 1800
-          ignored: PR Agent,E2E Rocks on pixv3,E2E InMemory on pixv3,E2E Rocks on pixv4,E2E InMemory on pixv4,E2E Rocks on cppv2,E2E InMemory on cppv2,Lint with unwrap expect panic
+          ignored: PR Agent,E2E Rocks on pixv3,E2E InMemory on pixv3,E2E Rocks on pixv4,E2E InMemory on pixv4,E2E Rocks on cppv2,E2E InMemory on cppv2

Cargo.toml

@@ -189,12 +189,9 @@ raft = []
 clone_on_ref_ptr = "warn"
 cloned_instead_of_copied = "warn"
 disallowed_names = "warn"
-expect_used = "warn"
 manual_let_else = "warn"
-panic = "warn"
 semicolon_if_nothing_returned = "warn"
 unused_async = "warn"
 unused_self = "warn"
-unwrap_used = "warn"
 used_underscore_binding = "warn"
 wildcard_imports = "warn"

build.rs

@@ -1,7 +1,3 @@
-#![allow(clippy::unwrap_used)]
-#![allow(clippy::expect_used)]
-#![allow(clippy::panic)]
-
 use std::collections::HashSet;
 use std::env;
 use std::fs;

justfile

@@ -67,8 +67,8 @@ lint:
     @just _lint
 
 # Stratus: Lint and check code formatting
-lint-check nightly-version="" clippy-flags="-D warnings":
-    @just _lint "{{nightly-version}}" --check "{{ clippy-flags }}"
+lint-check nightly-version="":
+    @just _lint "{{nightly-version}}" --check "-D warnings"
 
 # Stratus: Check for dependencies major updates
 outdated: