fix metrics bug

cloudwalk · Jun 7, 2024 · bf4de85 · bf4de85
1 parent ec0e65f
commit bf4de85
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/src/eth/consensus/mod.rs b/src/eth/consensus/mod.rs
@@ -716,7 +716,17 @@ impl AppendEntryService for AppendEntryServiceImpl {
         );
 
         #[cfg(feature = "metrics")]
-        metrics::set_append_entries_block_number_diff(last_last_arrived_block_number - header.number);
+        {
+            if let Some(diff) = last_last_arrived_block_number.checked_sub(header.number) {
+                metrics::set_append_entries_block_number_diff(diff);
+            } else {
+                tracing::error!(
+                    "leader is behind follower: arrived_block: {}, header_block: {}",
+                    last_last_arrived_block_number,
+                    header.number
+                );
+            }
+        }
 
         Ok(Response::new(AppendBlockCommitResponse {
             status: StatusCode::AppendSuccess as i32,