feat: implementing read_slots for rocks and inmemory by delegating to…

… read_slot (#574)
cloudwalk · Apr 12, 2024 · 10db006 · 10db006
1 parent 0332dac
commit 10db006
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 14 deletions.
diff --git a/src/eth/storage/inmemory/inmemory_permanent.rs b/src/eth/storage/inmemory/inmemory_permanent.rs
@@ -235,13 +235,18 @@ impl PermanentStorage for InMemoryPermanentStorage {
         }
     }
 
-    async fn read_slots(
-        &self,
-        _address: &Address,
-        _indexes: &[SlotIndex],
-        _point_in_time: &StoragePointInTime,
-    ) -> anyhow::Result<HashMap<SlotIndex, SlotValue>> {
-        todo!()
+    async fn read_slots(&self, address: &Address, indexes: &[SlotIndex], point_in_time: &StoragePointInTime) -> anyhow::Result<HashMap<SlotIndex, SlotValue>> {
+        tracing::debug!(%address, indexes_len = %indexes.len(), "reading slots");
+
+        let mut slots = HashMap::with_capacity(indexes.len());
+        for index in indexes {
+            let slot = self.read_slot(address, index, point_in_time).await?;
+            if let Some(slot) = slot {
+                slots.insert(slot.index, slot.value);
+            }
+        }
+
+        Ok(slots)
     }
 
     async fn read_block(&self, selection: &BlockSelection) -> anyhow::Result<Option<Block>> {

diff --git a/src/eth/storage/rocks/rocks_permanent.rs b/src/eth/storage/rocks/rocks_permanent.rs
@@ -138,13 +138,18 @@ impl PermanentStorage for RocksPermanentStorage {
         Ok(self.state.read_slot(address, index, point_in_time))
     }
 
-    async fn read_slots(
-        &self,
-        _address: &Address,
-        _indexes: &[SlotIndex],
-        _point_in_time: &StoragePointInTime,
-    ) -> anyhow::Result<HashMap<SlotIndex, SlotValue>> {
-        todo!()
+    async fn read_slots(&self, address: &Address, indexes: &[SlotIndex], point_in_time: &StoragePointInTime) -> anyhow::Result<HashMap<SlotIndex, SlotValue>> {
+        tracing::debug!(%address, indexes_len = %indexes.len(), "reading slots");
+
+        let mut slots = HashMap::with_capacity(indexes.len());
+        for index in indexes {
+            let slot = self.read_slot(address, index, point_in_time).await?;
+            if let Some(slot) = slot {
+                slots.insert(slot.index, slot.value);
+            }
+        }
+
+        Ok(slots)
     }
 
     async fn read_block(&self, selection: &BlockSelection) -> anyhow::Result<Option<Block>> {