Merge pull request #18 from cloudradar-monitoring/msi-fixes

Fix MSI upgrage and uninstall flow
cloudradar-monitoring · Oct 30, 2018 · 45bae69 · 45bae69
2 parents 10fcb22 + 73d98ad
commit 45bae69
Show file tree

Hide file tree

Showing 9 changed files with 50 additions and 86 deletions.
diff --git a/README.md b/README.md
@@ -31,8 +31,9 @@ goreleaser --snapshot
 ```
 
 ## Build MSI package
-– Should be done on Windows machine
-– Open command prompt(cmd.exe)
-– Go to cagent directory `cd path_to_directory`
-– Run `goreleaser --snapshot` to build binaries
-– Run `build-win.bat`
+Should be done on Windows machine
+- [Download go-msi](https://github.com/cloudradar-monitoring/go-msi/releases) and put it in the `C:\Program Files\go-msi`
+- Open command prompt(cmd.exe or powershell)
+- Go to cagent directory `cd path_to_directory`
+- Run `goreleaser --snapshot` to build binaries
+- Run `build-win.bat`
diff --git a/pkg-scripts/msi-templates/FolderUninstall.wxs b/pkg-scripts/msi-templates/FolderUninstall.wxs
@@ -0,0 +1,23 @@
+<?xml version="1.0"?>
+
+<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi" xmlns:util="http://schemas.microsoft.com/wix/UtilExtension">
+
+ <Fragment Id="FolderUninstall">
+     <?define RegDir="SYSTEM\ControlSet001\services\[Manufacturer]:[ProductName]"?>
+     <?define RegValueName="InstallDir"?>
+     <Property Id="INSTALLFOLDER">
+         <RegistrySearch Root="HKLM" Key="$(var.RegDir)" Type="raw"
+                   Id="APPLICATIONFOLDER_REGSEARCH" Name="$(var.RegValueName)" />
+     </Property>
+
+     <DirectoryRef Id='INSTALLDIR'>
+         <Component Id="UninstallFolder" Guid="*">
+             <CreateFolder Directory="INSTALLDIR"/>
+             <util:RemoveFolderEx Property="INSTALLDIR" On="uninstall"/>
+             <RemoveFolder Id="INSTALLDIR" On="uninstall"/>
+             <RegistryValue Root="HKLM" Key="$(var.RegDir)" Name="$(var.RegValueName)"
+                     Type="string" Value="[INSTALLDIR]" KeyPath="yes"/>
+         </Component>
+     </DirectoryRef>
+ </Fragment>
+</Wix>
diff --git a/pkg-scripts/msi-templates/WixUI_HK.wxs b/pkg-scripts/msi-templates/WixUI_HK.wxs
@@ -46,15 +46,19 @@
          <Publish Dialog="InstallDirDlg" Control="Next" Event="SetTargetPath" Value="[WIXUI_INSTALLDIR]" Order="1">1</Publish>
          <Publish Dialog="InstallDirDlg" Control="Next" Event="DoAction" Value="WixUIValidatePath" Order="2">NOT WIXUI_DONTVALIDATEPATH</Publish>
          <Publish Dialog="InstallDirDlg" Control="Next" Event="SpawnDialog" Value="InvalidDirDlg" Order="3"><![CDATA[NOT WIXUI_DONTVALIDATEPATH AND WIXUI_INSTALLDIR_VALID<>"1"]]></Publish>
-         <Publish Dialog="InstallDirDlg" Control="Next" Event="NewDialog" Value="ConfigDlg_HK" Order="4">WIXUI_DONTVALIDATEPATH OR WIXUI_INSTALLDIR_VALID="1"</Publish>
+
 
+         <Publish Dialog="InstallDirDlg" Control="Next" Event="NewDialog" Order="4" Value="VerifyReadyDlg">OLDERVERSIONBEINGUPGRADED AND WIXUI_INSTALLDIR_VALID="1"</Publish>
+         <Publish Dialog="InstallDirDlg" Control="Next" Event="NewDialog" Order="5" Value="ConfigDlg_HK">NOT OLDERVERSIONBEINGUPGRADED AND WIXUI_INSTALLDIR_VALID="1"</Publish>
          <Publish Dialog="ConfigDlg_HK" Control="Back" Event="NewDialog" Value="InstallDirDlg">1</Publish>
          <Publish Dialog="ConfigDlg_HK" Control="Next" Event="NewDialog" Value="VerifyReadyDlg">1</Publish>
 
          <Publish Dialog="InstallDirDlg" Control="ChangeFolder" Property="_BrowseProperty" Value="[WIXUI_INSTALLDIR]" Order="1">1</Publish>
          <Publish Dialog="InstallDirDlg" Control="ChangeFolder" Event="SpawnDialog" Value="BrowseDlg" Order="2">1</Publish>
 
-         <Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="MaintenanceTypeDlg" Order="2">Installed</Publish>
+         <Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Order="1" Value="InstallDirDlg">OLDERVERSIONBEINGUPGRADED AND WIXUI_INSTALLDIR_VALID="1"</Publish>
+         <Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Order="2" Value="ConfigDlg_HK">NOT OLDERVERSIONBEINGUPGRADED AND WIXUI_INSTALLDIR_VALID="1"</Publish>
+
 
          <Publish Dialog="MaintenanceWelcomeDlg" Control="Next" Event="NewDialog" Value="MaintenanceTypeDlg">1</Publish>
 

diff --git a/pkg-scripts/msi-templates/choco/LICENSE.txt b/pkg-scripts/msi-templates/choco/LICENSE.txt
diff --git a/pkg-scripts/msi-templates/choco/VERIFICATION.txt b/pkg-scripts/msi-templates/choco/VERIFICATION.txt
diff --git a/pkg-scripts/msi-templates/choco/chocolateyInstall.ps1 b/pkg-scripts/msi-templates/choco/chocolateyInstall.ps1
diff --git a/pkg-scripts/msi-templates/choco/chocolateyUninstall.ps1 b/pkg-scripts/msi-templates/choco/chocolateyUninstall.ps1
diff --git a/pkg-scripts/msi-templates/choco/pkg.nuspec b/pkg-scripts/msi-templates/choco/pkg.nuspec
diff --git a/pkg-scripts/msi-templates/product.wxs b/pkg-scripts/msi-templates/product.wxs
@@ -16,7 +16,7 @@
             Manufacturer="{{.Company}}"
             Language="1033">
 
-      <Package InstallerVersion="200" Compressed="yes" Comments="Windows Installer Package" InstallScope="perMachine"/>
+      <Package InstallerVersion="200" Compressed="yes" Comments="Windows Installer Package"/>
 
       <Media Id="1" Cabinet="product.cab" EmbedCab="yes"/>
 
@@ -34,18 +34,21 @@
                {{if gt (.Files.Items | len) 0}}
                <Component Id="ApplicationFiles" Guid="{{.Files.GUID}}">
                   {{range $i, $e := .Files.Items}}
-                    <File Id="ApplicationFile{{$i}}" Source="{{$e}}"/>
                      {{if eq $i 0}}
-                         <ServiceInstall Id="ServiceInstaller" Name="Cagent" Type="ownProcess" Vital="yes" DisplayName="Cagent" Description="Cagent" Start="auto" Account="LocalSystem" ErrorControl="normal" Arguments=" /start cagent" Interactive="no" />
-                         <ServiceControl Id="StartService" Name="Cagent" Stop="both" Start="install" Remove="uninstall" Wait="yes" />
-                    {{end}}
-                  {{end}}
+                         <ServiceInstall Id="ServiceInstaller" Name="Cagent" Type="ownProcess" Vital="yes" DisplayName="Cagent" Description="Cagent" Start="auto" Account="LocalSystem" ErrorControl="normal" Interactive="no">
+                         </ServiceInstall>
+                         <ServiceControl Id="StartService" Name="Cagent" Stop="both" Start="install" Remove="uninstall" Wait="yes">
+                               <ServiceArgument />
+                         </ServiceControl>
+                     {{end}}
+               	     <File Id="ApplicationFile{{$i}}" Source="{{$e}}"/>
+		         {{end}}
                </Component>
                {{end}}
                {{if gt (.Directories | len) 0}}
-               {{range $i, $e := .Directories}}
-               <Directory Id="APPDIR{{$i}}" Name="{{$e}}" />
-               {{end}}
+                  {{range $i, $e := .Directories}}
+                     <Directory Id="APPDIR{{$i}}" Name="{{$e}}" />
+                 {{end}}
                {{end}}
             </Directory>
          </Directory>
@@ -137,6 +140,9 @@
          {{range $i, $e := .Directories}}
          <ComponentGroupRef Id="AppFiles{{$i}}" />
          {{end}}
+         <Feature Id="Uninstall">
+             <ComponentRef Id="UninstallFolder" Primary="yes"/>
+         </Feature>
       </Feature>
 
       <UI>