-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cluster): Add replication slots configuration #356
base: main
Are you sure you want to change the base?
feat(cluster): Add replication slots configuration #356
Conversation
778ac48
to
086347f
Compare
086347f
to
4cd6453
Compare
charts/cluster/values.yaml
Outdated
replicationSlots: | ||
highAvailability: | ||
enabled: true | ||
slotPrefix: _cnpg_ | ||
updateInterval: "30" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you replace this with:
replicationSlots: {}
# highAvailability:
# enabled: true
# slotPrefix: _cnpg_
# updateInterval: "30"
and then re-run make schema docs
.
Otherwise the generated schema is incorrect and would not allow otherwise valid configurations. This way it would only validate whether it's passed an object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I not get a bit what you mean. This will be this way, what else can be set outside of this schema?
I specially set highAvailability, as it always has place even when it unset in CRD, it just turned on by default with this settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to the API reference here: https://cloudnative-pg.io/documentation/current/cloudnative-pg.v1/#postgresql-cnpg-io-v1-ReplicationSlotsConfiguration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that our schema is auto generated based on values, so it will assume the structure you provided, which is incomplete. Run make schema
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found and fixed issue, thanks
Signed-off-by: Dmitriy Alekseev <[email protected]>
4cd6453
to
e88e0af
Compare
implements: #354