Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 compatibility #20

Closed
wants to merge 3 commits into from
Closed

PHP 8.4 compatibility #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ca03a2
Add PHP 8.3 and 8.4 to matrix
ruudk Oct 31, 2024
2b9d5b0
Make compatible with PHP 8.4
ruudk Oct 31, 2024
efbd062
Make compatible with PHP 8.4
ruudk Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ jobs:
- '8.0'
- '8.1'
- '8.2'
- '8.3'
- '8.4'
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion src/Transformation/BaseAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function __construct(...$qualifiers)
*
* @return $this
*/
public function addQualifier(BaseComponent $qualifier = null)
public function addQualifier(?BaseComponent $qualifier = null)
{
ArrayUtils::addNonEmpty($this->qualifiers, $qualifier ? $qualifier->getFullName() : null, $qualifier);

Expand Down
4 changes: 2 additions & 2 deletions src/Transformation/Qualifier/QualifierValue/QualifierMultiValue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public function addValues(...$values)
*
* @internal
*/
public function setValue(BaseComponent $value = null)
public function setValue(?BaseComponent $value = null)
{
return $this->setSimpleValue($value ? $value->getName() : null, $value);
}
Expand Down Expand Up @@ -186,7 +186,7 @@ public function getSimpleValue($name)
*
* @internal
*/
public function setNamedValue(BaseComponent $value = null)
public function setNamedValue(?BaseComponent $value = null)
{
return $this->setSimpleNamedValue($value ? $value->getName() : null, $value);
}
Expand Down
Loading