Merge pull request #543 from cloudinary/ME-3762-import-statements-in-…

…code-snippets Add importStatementsTemplate to langConfig
cloudinary · Dec 2, 2022 · bd67553 · bd67553
2 parents 93e9d0a + 1c52c64
commit bd67553
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 6 deletions.
diff --git a/.code-generation/config.js b/.code-generation/config.js
@@ -62,7 +62,11 @@ module.exports = {
       }
     },
     unsupportedTxParams: ['fl_waveform', 'e_theme', 'af_'],
-    unsupportedSyntaxList: ['.stroke(', '.textFit(', 'Animated.edit', '.RoundCorners(', 'getVideoFrame']
+    unsupportedSyntaxList: ['.stroke(', '.textFit(', 'Animated.edit', '.RoundCorners(', 'getVideoFrame'],
+    importStatementsTemplate: {
+      action: `import { <NAME> } from "@cloudinary/url-gen/actions/<GROUP>";`,
+      qualifier: `import { <NAME> } from "@cloudinary/url-gen/qualifiers/<GROUP>";`,
+    }
   },
   "overwrites": {
     qualifiers: {

diff --git a/.travis.yml b/.travis.yml
@@ -1,7 +1,9 @@
+dist: focal
 language: node_js
 node_js:
-  - "12"
   - "14"
+  - "16"
+#  - "18" # Not supported yet (ref. error:0308010C:digital envelope routines::unsupported)
 script:
   - npm run lint
   - npm run test

diff --git a/__TESTS_BUNDLE_SIZE__/bundleSizeTestCases.ts b/__TESTS_BUNDLE_SIZE__/bundleSizeTestCases.ts
@@ -74,7 +74,7 @@ const bundleSizeTestCases:ITestCase[] = [
   },
   {
     name: 'Import all of the SDK',
-    sizeLimitInKB: 128,
+    sizeLimitInKB: 129,
     importsArray: [
       importFromPackage('* as CloudinaryURLGEN')
     ]
@@ -88,7 +88,7 @@ const bundleSizeTestCases:ITestCase[] = [
   },
   {
     name: 'Import All Actions',
-    sizeLimitInKB: 55,
+    sizeLimitInKB: 56,
     importsArray: [
       importFromPackage('Actions')
     ]

diff --git a/src/backwards/utils/legacyBaseUtil.ts b/src/backwards/utils/legacyBaseUtil.ts
@@ -18,7 +18,8 @@ export const withCamelCaseKeys = function(source: {}) {
  * @return {string} in camelCase format
  */
 export const camelCase = function(source: string) {
-  var words = source.match(reWords);
+  let words : string[] = source.match(reWords);
+
   words = words.map(word=> word.charAt(0).toLocaleUpperCase() + word.slice(1).toLocaleLowerCase());
   words[0] = words[0].toLocaleLowerCase();
 

diff --git a/tsconfig.json b/tsconfig.json
@@ -8,6 +8,7 @@
     "esModuleInterop": true,
     "resolveJsonModule": true,
     "allowJs": true,
+    "skipLibCheck": true
   },
   "include": [
     "src"

diff --git a/tsconfig.test.json b/tsconfig.test.json
@@ -6,7 +6,8 @@
     "moduleResolution": "node",
     "esModuleInterop": true,
     "noEmit": true,
-    "resolveJsonModule": true
+    "resolveJsonModule": true,
+    "skipLibCheck": true
   },
   "include": [
     "src",