Update transformation types for Cloudinary Video Player #202 #215
Conversation
|
Hey @colbyfayock |
|
looks like a linting error. you can run pnpm run lint from the root of the project 
|
| @@ -495,4 +499,343 @@ export interface CloudinaryVideoPlayerOptionsCloudinaryAnalyticsCustomData { | |||
| customData3?: string; | |||
| customData4?: string; | |||
| customData5?: string; | |||
| } | |||
|
|
|||
| export type AudioCodecType = string | "none" | "aac" | "vorbis" | "mp3"; | |||
There was a problem hiding this comment.
do we need all of these types copy and pasted into here now that we're using the Transformation type directly from the url-gen package? i thought we'd only relaly need to import that
There was a problem hiding this comment.
Should be able to, for the most part, copy in all of the types from the above int othe types/cloudinary-video-player.ts file
Isn't changes are correct?
According to issue need to copy from there!
Let me know how can I proceed here
There was a problem hiding this comment.
yeah apologies for the confusion, i thought we had decided that instead of copying in the type,s we would import it from the url-gen package, and i THINK that should be sufficient. so then you would point the video player transformation property to the imported type
Description
Update transformation types for Cloudinary Video Player
Dependency: @cloudinary/url-gen
Issue Ticket Number
Fixes #202
Type of change
Checklist