Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove anything related to building softlayer. #394

Open
wants to merge 2 commits into
base: ubuntu-noble
Choose a base branch
from

Conversation

ramonskie
Copy link
Contributor

this will remove anything related to softlayer.

the bosh-stemcell/spec/support/stemcell_image.rb had 1 big if condition with testing shellout types.
i tested the part removed and it works as expected

@rkoster
Copy link
Contributor

rkoster commented Nov 28, 2024

Softlayer cpi has been archived here: cloudfoundry/community#1023

@rkoster rkoster requested review from a team, rajathagasthya and bgandon and removed request for a team November 28, 2024 16:03
Copy link
Contributor

@benjaminguttmann-avtq benjaminguttmann-avtq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside comment

# if `config.filter[exclude_on_softlayer]` is set, it means you're building the SoftLayer stemcell.
which still mentions softlayer it looks good to me

Copy link
Contributor

@benjaminguttmann-avtq benjaminguttmann-avtq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pending Review | Discussion
Development

Successfully merging this pull request may close these issues.

4 participants