fix(ci): workaround skipped jobs being considered successful #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Issue Due to actions/runner#2566 skipped "Result" jobs are considered succesful checks. This breaks our PR validation. # Fix Introduce an ugly workaround: A new Result job that will be always skipped except when a required job fails, in which case it also fails.
silvestre
force-pushed
the
fix-pr-acceptance-workflow
branch
from
0506723
to
5db2e1c
Compare
|
Fails now as expected, e.g. when manually cancelling the deployment:
|
|
The successful case has a skipped "Result" step: |
|
Again, now that all checks have "passed":
|
asalan316
approved these changes
Nov 29, 2024
# Issue Due to fail-fast we were getting less feedback per run, making the feedback loop slower. # Fix With fail-fast: false other matrix jobs will be cancelled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Due to actions/runner#2566 skipped "Result" jobs are considered successful checks. This breaks our PR validation.
Fix
Introduce an ugly workaround: A new Result job that will be always skipped except when a required job fails, in which case it also fails.
Note
We could probably improve the naming and not call it "Result" but "Acceptance test failure blocker" or something to that end, but as the branch protection is controlled via another repo, let's keep it for now until we have validated everything to work as intended.