Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-> remove contrainst not null #3297

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix-> remove contrainst not null #3297

merged 1 commit into from
Oct 29, 2024

Conversation

asalan316
Copy link
Contributor

@asalan316 asalan316 commented Oct 28, 2024 •
edited
Loading

As part of PR#3211, an additional column custom_metrics_strategy was added which can be null

This PR fixes the not null constraint from liquibase side

 Starting Liquibase at 17:44:58 using Java 21.0.5 (version 4.29.2 #3683 built at 2024-08-29 16:45+0000)
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | Running Changeset: var/vcap/packages/golangapiserver/servicebroker.db.changelog.yaml::5::Arsalan
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout |
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | UPDATE SUMMARY
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | Run:                          0
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | Previously run:               4
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | Filtered out:                 0
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | -------------------------------
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | Total change sets:            7
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout |
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | ERROR: Exception Details
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | ERROR: Exception Primary Class:  PSQLException
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | ERROR: Exception Primary Reason:  ERROR: column "custom_metrics_strategy" of relation "binding" contains null values
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | ERROR: Exception Primary Source:  PostgreSQL 15.7
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout | Unexpected error running Liquibase: liquibase.exception.MigrationFailedException: Migration failed for changeset var/vcap/packages/golangapiserver/servicebroker.db.changelog.yaml::5::Arsalan:
apiserver/bd8aa6fb-3e0f-4d22-b9a6-df96ff7a62b2: stdout |      Reason: liquibase.exception.DatabaseException: ERROR: co

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@asalan316 asalan316 added the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label Oct 28, 2024
bonzofenix
bonzofenix approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@bonzofenix bonzofenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asalan316 asalan316 merged commit eaf416f into main Oct 29, 2024
45 of 48 checks passed
@asalan316 asalan316 deleted the autoscaler-fixes-neighbour-app branch October 29, 2024 10:26
@asalan316 asalan316 added the bug label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonzofenix bonzofenix bonzofenix approved these changes

Assignees
No one assigned
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asalan316 @bonzofenix