feat(metricsforwarder): Directly write to Log Cache via Syslog protocol #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzofenix
added
the
allow-acceptance-tests
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ca_file: metron_client/ca.crt | ||
| db: | ||
| policy_db: | ||
| url: postgres://postgres:CHANGE_ME@some-service:5432/autoscaler |
Check failure
Code scanning / SonarCloud
PostgreSQL database passwords should not be disclosed
| connection_max_lifetime: 60s | ||
|
|
||
| storedprocedure_db: | ||
| url: postgres://postgres:CHANGE_ME@some-service:5432/autoscaler |
Check failure
Code scanning / SonarCloud
PostgreSQL database passwords should not be disclosed
bonzofenix
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bonzofenix
force-pushed
the
metricforwarder-on-cf
branch
2 times, most recently
from
b2abedd
to
6718757
Compare
bonzofenix
force-pushed
the
metricforwarder-on-cf
branch
from
5da618c
to
f6ef81b
Compare
bonzofenix
force-pushed
the
metricforwarder-on-cf
branch
from
6ec0348
to
b6a52a1
Compare
bonzofenix
changed the title
bonzofenix
force-pushed
the
metricforwarder-on-cf
branch
from
a3d39de
to
676613d
Compare
Long deployments names generate longer than posible urls and can break certificate generation process when running a bosh deploy.
geigerj0
reviewed
May 28, 2024
geigerj0
reviewed
May 28, 2024
geigerj0
reviewed
May 28, 2024
geigerj0
reviewed
May 28, 2024
geigerj0
reviewed
May 29, 2024
…log" This reverts commit 5ad72de.
Prometheus metrics and health enpoint will be address globally once the we know whats the best way to address this issue when running autoscaler components as cf apps.
geigerj0
approved these changes
May 29, 2024
|
auto-merge was automatically disabled
May 29, 2024 18:25
Rebase failed
silvestre
added
enhancement
and removed
dependencies
silvestre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of an ongoing effort to get app autoscaler components running on CF, an alternative way to send custom metrics to log-cache from metricforwarder needs to be found.
Current implementation relays on direct connection within the metrics forwarder VM to a locally run metro-agent process. If the goals is to get Metricfowarder running as a CF app, CF container would need access to a metron-agent on the host machine, in this case a Diego cell, which would not be set up by as the same way it is being run now.
Alternatively we can relay on the log-cache syslog-server, while opening traffic from a cf container to the log-cache vm provision by the CF deployment.
This PR intends to default metricforwarder to write to the syslog-server directly instead of using a locally running agent.