Trim down tools.go usage
#2072
Merged
Trim down tools.go usage
#2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvestre
added
chore
allow-acceptance-tests
silvestre
force-pushed
the
deps
branch
2 times, most recently
from
6b1590c
to
a2f19a2
Compare
`tools.go` should only import packages that are used when running go generate and not be used as a generic tool installer, for that we use `.tool-versions` and the Nix flake.
and fix/ignore found issues
some where even missing their generate statement
Generating all fakes at once seems to compound some memory leak. Memory usage goes from 1GiB to 17GiB, which does not work on GitHub hosted runners.
|
Kudos, SonarCloud Quality Gate passed!
|
joergdw
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools.gousagetools.goshould only import packages that are used when running gogenerate and not be used as a generic tool installer, for that we use
.tool-versionsand the Nix flake.go:buildstatements