Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAPI specification for the public API #1755

Merged
merged 45 commits into from
Aug 18, 2023
Merged

Add OpenAPI specification for the public API #1755

merged 45 commits into from
Aug 18, 2023

Conversation

joergdw
Copy link
Contributor

@joergdw joergdw commented May 11, 2023

No description provided.

@joergdw joergdw requested a review from a team May 11, 2023 09:59
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@silvestre
Copy link
Member

/easycla

.direnv/flake-profile Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
Copy link
Member

@silvestre silvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned changes to the test app were necessary and I was curious to see why.

api/custom-metrics-api.openapi.yaml Outdated Show resolved Hide resolved
src/acceptance/assets/app/go_app/internal/generate.go Outdated Show resolved Hide resolved
silvestre
silvestre previously approved these changes Aug 16, 2023
Copy link
Member

@silvestre silvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from one question.

src/acceptance/assets/app/go_app/Makefile Outdated Show resolved Hide resolved
@silvestre silvestre changed the title Re-Format custom-metrics-api and start scaling-history-api (WIP); Add OpenAPI specification for the public API Aug 16, 2023
anubhav-gupta1
anubhav-gupta1 previously approved these changes Aug 18, 2023
@joergdw joergdw enabled auto-merge August 18, 2023 08:50
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joergdw joergdw merged commit 5b53157 into main Aug 18, 2023
42 checks passed
@joergdw joergdw deleted the openapi-specs branch August 18, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants