Add tests for github service, and move all github deployments logic t…

…o be inside of github.ts

.changeset/bright-dryers-kneel.md

@@ -0,0 +1,5 @@
+---
+"wrangler-action": minor
+---
+
+Add GitHub deployments and job summaries for parity with pages-action

.github/workflows/deploy.yml

@@ -30,7 +30,7 @@ jobs:
       - name: Only build app
         uses: ./
         with:
-          workingDirectory: "./test/only-build"
+          workingDirectory: "./src/test/fixtures/only-build"
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           command: deploy --dry-run
@@ -39,15 +39,15 @@ jobs:
         uses: ./
         with:
           quiet: true
-          workingDirectory: "./test/build-quiet"
+          workingDirectory: "./src/test/fixtures/build-quiet"
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           command: deploy --dry-run
 
       - name: Environment support
         uses: ./
         with:
-          workingDirectory: "./test/environment"
+          workingDirectory: "./src/test/fixtures/environment"
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           environment: dev
@@ -65,7 +65,7 @@ jobs:
         uses: ./
         with:
           wranglerVersion: "2.20.0"
-          workingDirectory: "./test/secrets-v2"
+          workingDirectory: "./src/test/fixtures/secrets-v2"
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           secrets: |
@@ -82,7 +82,7 @@ jobs:
       - name: Deploy app secrets w/ default version
         uses: ./
         with:
-          workingDirectory: "./test/secrets-default"
+          workingDirectory: "./src/test/fixtures/secrets-default"
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           secrets: |
@@ -99,7 +99,7 @@ jobs:
       - name: Clean Up Deployed Workers
         uses: ./
         with:
-          workingDirectory: "./test/secrets-default"
+          workingDirectory: "./src/test/fixtures/secrets-default"
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           command: delete --name wrangler-action-test-secrets-v2 --force
@@ -109,7 +109,7 @@ jobs:
       - name: Support packageManager variable
         uses: ./
         with:
-          workingDirectory: "./test/specify-package-manager"
+          workingDirectory: "./src/test/fixtures/specify-package-manager"
           packageManager: "npm"
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
@@ -118,15 +118,15 @@ jobs:
       - name: Support unspecified packageManager with no lockfile
         uses: ./
         with:
-          workingDirectory: "./test/unspecified-package-manager"
+          workingDirectory: "./src/test/fixtures/unspecified-package-manager"
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           command: deploy --dry-run
 
       - name: Support npm package manager
         uses: ./
         with:
-          workingDirectory: "./test/npm"
+          workingDirectory: "./src/test/fixtures/npm"
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           command: deploy --dry-run
@@ -137,7 +137,7 @@ jobs:
       - name: Support yarn package manager
         uses: ./
         with:
-          workingDirectory: "./test/yarn"
+          workingDirectory: "./src/test/fixtures/yarn"
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           command: deploy --dry-run
@@ -148,18 +148,18 @@ jobs:
       - name: Support pnpm package manager
         uses: ./
         with:
-          workingDirectory: "./test/pnpm"
+          workingDirectory: "./src/test/fixtures/pnpm"
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           command: deploy --dry-run
 
       - name: Change directory to pre-installed-wrangler and install dependencies
         run: |
-          cd ./test/pre-installed-wrangler
+          cd ./src/test/fixtures/pre-installed-wrangler
           npm install
 
       - name: Support pre-installed wrangler
         uses: ./
         with:
-          workingDirectory: "./test/pre-installed-wrangler"
+          workingDirectory: "./src/test/fixtures/pre-installed-wrangler"
           command: action-test

package.json

@@ -38,6 +38,7 @@
 		"@changesets/changelog-github": "^0.5.0",
 		"@changesets/cli": "^2.27.9",
 		"@cloudflare/workers-types": "^4.20241022.0",
+		"@types/mock-fs": "^4.13.4",
 		"@types/node": "^22.9.0",
 		"@types/semver": "^7.5.8",
 		"@vercel/ncc": "^0.38.2",

src/packageManagers.test.ts

@@ -3,35 +3,39 @@ import { getPackageManager } from "./packageManagers";
 
 describe("getPackageManager", () => {
 	test("should use provided value instead of inferring from lockfile", () => {
-		expect(getPackageManager("npm", { workingDirectory: "src/test/fixtures/npm" }))
-			.toMatchInlineSnapshot(`
+		expect(
+			getPackageManager("npm", { workingDirectory: "src/test/fixtures/npm" }),
+		).toMatchInlineSnapshot(`
 				{
 				  "exec": "npx",
 				  "execNoInstall": "npx --no-install",
 				  "install": "npm i",
 				}
 			`);
 
-		expect(getPackageManager("yarn", { workingDirectory: "src/test/fixtures/npm" }))
-			.toMatchInlineSnapshot(`
+		expect(
+			getPackageManager("yarn", { workingDirectory: "src/test/fixtures/npm" }),
+		).toMatchInlineSnapshot(`
 				{
 				  "exec": "yarn",
 				  "execNoInstall": "yarn",
 				  "install": "yarn add",
 				}
 			`);
 
-		expect(getPackageManager("pnpm", { workingDirectory: "src/test/fixtures/npm" }))
-			.toMatchInlineSnapshot(`
+		expect(
+			getPackageManager("pnpm", { workingDirectory: "src/test/fixtures/npm" }),
+		).toMatchInlineSnapshot(`
 				{
 				  "exec": "pnpm exec",
 				  "execNoInstall": "pnpm exec",
 				  "install": "pnpm add",
 				}
 			`);
 
-		expect(getPackageManager("bun", { workingDirectory: "src/test/fixtures/bun" }))
-			.toMatchInlineSnapshot(`
+		expect(
+			getPackageManager("bun", { workingDirectory: "src/test/fixtures/bun" }),
+		).toMatchInlineSnapshot(`
 				{
 				  "exec": "bunx",
 				  "execNoInstall": "bun run",
@@ -52,8 +56,9 @@ describe("getPackageManager", () => {
 	});
 
 	test("should use yarn if no value provided and yarn.lock exists", () => {
-		expect(getPackageManager("", { workingDirectory: "src/test/fixtures/yarn" }))
-			.toMatchInlineSnapshot(`
+		expect(
+			getPackageManager("", { workingDirectory: "src/test/fixtures/yarn" }),
+		).toMatchInlineSnapshot(`
 				{
 				  "exec": "yarn",
 				  "execNoInstall": "yarn",
@@ -63,8 +68,9 @@ describe("getPackageManager", () => {
 	});
 
 	test("should use pnpm if no value provided and pnpm-lock.yaml exists", () => {
-		expect(getPackageManager("", { workingDirectory: "src/test/fixtures/pnpm" }))
-			.toMatchInlineSnapshot(`
+		expect(
+			getPackageManager("", { workingDirectory: "src/test/fixtures/pnpm" }),
+		).toMatchInlineSnapshot(`
 				{
 				  "exec": "pnpm exec",
 				  "execNoInstall": "pnpm exec",
@@ -85,8 +91,9 @@ describe("getPackageManager", () => {
 	});
 
 	test("should use npm if no value provided and no lockfile is present", () => {
-		expect(getPackageManager("", { workingDirectory: "src/test/fixtures/empty" }))
-			.toMatchInlineSnapshot(`
+		expect(
+			getPackageManager("", { workingDirectory: "src/test/fixtures/empty" }),
+		).toMatchInlineSnapshot(`
 				{
 				  "exec": "npx",
 				  "execNoInstall": "npx --no-install",

src/service/github.spec.ts

@@ -0,0 +1,59 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { setupServer } from "msw/node";
+import { createGitHubDeployment, createJobSummary } from "./github";
+import { getOctokit } from "@actions/github";
+import { mockGithubDeployments } from "../test/mocks";
+import { getTestConfig } from "../test/test-utils";
+import mockfs from "mock-fs";
+import { readFile } from "fs/promises";
+
+afterEach(() => {
+	mockfs.restore();
+});
+
+describe("github", () => {
+	it("Calls createGitHubDeployment successfully", async () => {
+		const githubUser = "mock-user";
+		const githubRepoName = "wrangler-action";
+		const server = setupServer(
+			...mockGithubDeployments({ githubUser, githubRepoName }).handlers,
+		);
+		server.listen({ onUnhandledRequest: "error" });
+		vi.stubEnv("GITHUB_REPOSITORY", `${githubUser}/${githubRepoName}`);
+
+		const testConfig = getTestConfig();
+		const octokit = getOctokit(testConfig.GITHUB_TOKEN, { request: fetch });
+		await createGitHubDeployment({
+			config: testConfig,
+			octokit,
+			productionBranch: "production-branch",
+			deploymentId: "fake-deployment-id",
+			projectName: "fake-project-name",
+			deploymentUrl: "https://fake-deployment-url.com",
+			environment: "production",
+		});
+		server.close();
+	});
+	it("Calls createJobSummary successfully", async () => {
+		vi.stubEnv("GITHUB_STEP_SUMMARY", "summary");
+		mockfs({
+			summary: mockfs.file(),
+		});
+		await createJobSummary({
+			commitHash: "fake-commit-hash",
+			deploymentUrl: "https://fake-deployment-url.com",
+			aliasUrl: "https://fake-alias-url.com",
+		});
+		expect((await readFile("summary")).toString()).toMatchInlineSnapshot(`
+			"
+			# Deploying with Cloudflare Pages
+
+			| Name                    | Result |
+			| ----------------------- | - |
+			| **Last commit:**        | fake-commit-hash |
+			| **Preview URL**:        | https://fake-deployment-url.com |
+			| **Branch Preview URL**: | https://fake-alias-url.com |
+			  "
+		`);
+	});
+});