Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build and push subcommands to cloudchamber #7378

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IRCody
Copy link
Contributor

@IRCody IRCody commented Nov 27, 2024

Describe your change...
Add build and push subcommands to cloudchamber that build a docker image and push to the cloudchamber managed registry using a local docker daemon.

I wanted to get feedback on behavior/approach now but making a draft because still some todos:

  • Testing the interaction with docker by mocking the docker calls to make sure we are passing the intended flags.
  • Clean up the ux/command descriptions.

  • Tests
    • TODO (before merge)- some basic tests included but need to add some more before merge.
    • [] Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • [] Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 2582f19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant