Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some more properties to telemetry events #7320

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Nov 21, 2024

DEVX-1512 - add argsUsed, argsCombination, isCI and isInteractive

also redact string arg values


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: unit tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: attaching to main PR

@emily-shen emily-shen requested a review from a team as a code owner November 21, 2024 20:22
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: a1950bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emily-shen emily-shen changed the base branch from main to wrangler-telemetry November 21, 2024 20:23
Copy link
Contributor

github-actions bot commented Nov 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11971029461/npm-package-wrangler-7320

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7320/npm-package-wrangler-7320

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11971029461/npm-package-wrangler-7320 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11971029461/npm-package-create-cloudflare-7320 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11971029461/npm-package-cloudflare-kv-asset-handler-7320
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11971029461/npm-package-miniflare-7320
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11971029461/npm-package-cloudflare-pages-shared-7320
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11971029461/npm-package-cloudflare-vitest-pool-workers-7320
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11971029461/npm-package-cloudflare-workers-editor-shared-7320
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11971029461/npm-package-cloudflare-workers-shared-7320
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11971029461/npm-package-cloudflare-workflows-shared-7320

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen force-pushed the emily/expand-properties branch 2 times, most recently from d470e73 to bcb3aa7 Compare November 22, 2024 10:38
@emily-shen emily-shen merged commit 97a03e1 into wrangler-telemetry Nov 22, 2024
31 of 33 checks passed
@emily-shen emily-shen deleted the emily/expand-properties branch November 22, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants