Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert versions list to defineCommand #7293

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andyjessop
Copy link
Contributor

Fixes #000.

Part of the ongoing refactor to convert all commands to use defineCommand (see here: #6655)


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: No logic added
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Internal only

@andyjessop andyjessop added the e2e Run e2e tests on a PR label Nov 19, 2024
@andyjessop andyjessop requested a review from a team as a code owner November 19, 2024 16:35
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 2105933

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@andyjessop andyjessop changed the title chore convert versions list to defineCommand chore: convert versions list to defineCommand Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11952850987/npm-package-wrangler-7293

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7293/npm-package-wrangler-7293

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11952850987/npm-package-wrangler-7293 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11952850987/npm-package-create-cloudflare-7293 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11952850987/npm-package-cloudflare-kv-asset-handler-7293
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11952850987/npm-package-miniflare-7293
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11952850987/npm-package-cloudflare-pages-shared-7293
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11952850987/npm-package-cloudflare-vitest-pool-workers-7293
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11952850987/npm-package-cloudflare-workers-editor-shared-7293
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11952850987/npm-package-cloudflare-workers-shared-7293
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11952850987/npm-package-cloudflare-workflows-shared-7293

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@andyjessop andyjessop marked this pull request as draft November 19, 2024 17:00
@andyjessop andyjessop force-pushed the aj/define-command-versions-list branch from 95a5c99 to 3fc7407 Compare November 21, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR no-changeset-required
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant