Make debug log for .env not found less scary
#7272
Open
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6213ba4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977570627/npm-package-wrangler-7272You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7272/npm-package-wrangler-7272Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977570627/npm-package-wrangler-7272 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977570627/npm-package-create-cloudflare-7272 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977570627/npm-package-cloudflare-kv-asset-handler-7272npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977570627/npm-package-miniflare-7272npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977570627/npm-package-cloudflare-pages-shared-7272npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977570627/npm-package-cloudflare-vitest-pool-workers-7272npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977570627/npm-package-cloudflare-workers-editor-shared-7272npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977570627/npm-package-cloudflare-workers-shared-7272npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11977570627/npm-package-cloudflare-workflows-shared-7272Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
emily-shen
reviewed
Nov 18, 2024
| @@ -670,7 +670,11 @@ function tryLoadDotEnv(path: string): DotEnv | undefined { | |||
| const parsed = dotenv.parse(fs.readFileSync(path)); | |||
| return { path, parsed }; | |||
| } catch (e) { | |||
| logger.debug(`Failed to load .env file "${path}":`, e); | |||
| if ((e as { code: string }).code === "ENOENT") { | |||
| logger.debug(`.env file not found at "${path}"`); | |||
There was a problem hiding this comment.
definitely less scary but it still could be mistaken for an error - can we add a short message to say this is fine to ignore if you're not trying to use .dev.vars, .env etc.?
vicb
reviewed
Nov 22, 2024
petebacondarwin
approved these changes
Nov 22, 2024
penalosa
force-pushed
the
penalosa/env-file-debug
branch
from
f737b3c
to
6213ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7042