Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional routing field to regional hostname #4514

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tarnfeld
Copy link

@tarnfeld tarnfeld commented Nov 5, 2024

(WIP)

Introducing a new, and very optional routing field into the Regional Hostname API.
Schema and cloudflare-go library changes are not yet released.

I'm not sure if this empty checks are required, but since this field is very optional right now, I would prefer we don't generate a load of routing = "" config in terraform objects when it's redundant.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included and you have permission, please add the workflow/skip-changelog-entry label. Otherwise, a maintainer will add the label or ask you for one when they review the PR.

Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@jacobbednarz
Copy link
Member

moving to draft to keep stalebot of it. feel free to flip it back when you're ready here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants