-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for creating queue consumers #3833
base: master
Are you sure you want to change the base?
Conversation
pullgin updates
A consumer support
changelog detected ✅ |
Signed-off-by: Chris Lyons <[email protected]>
Could you review the apaproach I took here? Also, I am having issues with what seems like writing configuration to cloudflare aand then reading the configuration back. Also, this PR is not complete yet so dont merge... |
Signed-off-by: Chris Lyons <[email protected]>
what do you specifically want review for the approach here? it's largely copy/paste of what we've done for other products so that seems fine. as for the queue consumer specific stuff, i've pinged some folks internally as to how this should operate/be used since i'm not familiar with the product. |
Signed-off-by: Chris Lyons <[email protected]>
Still working on it. If you think the approach is fine, that is all I need. I am having some difficulty with getting the schemaa right for the consumers array that I want to add to the Q object... Once I can get that working I think the rest will be pretty easy. |
Signed-off-by: Chris Lyons <[email protected]>
Im trying to get this schema to work for the consumers: consumers = [ as it looks like there can be multiple consumers and I want to support that. If you have any advice for how to define the schema or a better way to adjust it, let me know. Ill keep fighting with it until I get it right. |
Signed-off-by: Chris Lyons <[email protected]>
Signed-off-by: Chris Lyons <[email protected]>
Signed-off-by: Chris Lyons <[email protected]>
Signed-off-by: Chris Lyons <[email protected]>
No description provided.