Begin to write integration tests for service + controller #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| for k := range wc.handlers { | ||
| allowed = append(allowed, GetMethodName(k)) | ||
| } | ||
|
|
||
| wc.allowed = strings.Join(allowed, ",") | ||
| // Sort the HTTP methods |
There was a problem hiding this comment.
Mainly done for testing purposes
|
Ping @buro9 |
AntoineAugusti
force-pushed
the
integration-tests-service-controller
branch
from
b66b1ed to
bd93717
Compare
|
Any comments @buro9? |
|
Bump ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR even if it's not finished yet as I'd love some feedback. My goal is to write some integration tests for the service and controller components mainly.
This PR could also be a great opportunity to set up some kind of continuous integration, to fight against regressions.
My questions: