Add SchemaType for accessing the type ID of a type defined in a schema
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is essentially the same as capnp::HasTypeId
zebp
approved these changes
Oct 30, 2024
| @@ -301,6 +303,10 @@ to_tokens!( | |||
| #[derive(Clone)] | |||
| pub struct #name<T = _p::Family>(T); | |||
|
|
|||
| impl _p::ty::SchemaType for #name { | |||
| const ID: u64 = #id; | |||
There was a problem hiding this comment.
Very minor nit, but the go/cpp/and existing rust generators generate hex ids so it'd be nice to also use a hex literal just to make it easier to compare across codebases.
mikea
reviewed
Nov 6, 2024
| @@ -702,6 +709,10 @@ to_tokens!( | |||
| #(#enumerants),* | |||
| } | |||
|
|
|||
| impl _p::ty::SchemaType for #name { | |||
| const ID: u64 = #id; | |||
mikea
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially the same as capnp::HasTypeId