Remove max_batch_size from Latest
#723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoyla
force-pushed
the
jhoyla/remove-max-batch-size
branch
3 times, most recently
from
fc12d17
to
9d8ef7d
Compare
jhoyla
requested review from
armfazh,
bhalleycf,
cjpatton,
fisherdarling,
cbranch,
lbaquerofierro,
mendess,
Noah-Kennedy and
RageKnify
as code owners
jhoyla
changed the base branch from
main
to
jhoyla/remove-multibatch-collection
armfazh
approved these changes
Nov 25, 2024
jhoyla
force-pushed
the
jhoyla/remove-max-batch-size
branch
from
9d8ef7d
to
2350d6c
Compare
mendess
reviewed
Nov 26, 2024
crates/daphne/src/lib.rs
Outdated
| @@ -732,7 +732,7 @@ impl DapTaskConfig { | |||
| DapQueryConfig::FixedSize { | |||
| max_batch_size: Some(max_batch_size), | |||
| } => { | |||
| if report_count > max_batch_size { | |||
| if (report_count > u64::from(max_batch_size)) && max_batch_size != 0 { | |||
There was a problem hiding this comment.
why are you checking that max_batch_size != 0 here?
There was a problem hiding this comment.
Per the old draft a max_batch_size of 0 means there is no limit.
The maximum batch size for fixed_size query is optional. If query_type is fixed_size and max_batch_size is 0, then the task does not have maximum batch size limit.
https://datatracker.ietf.org/doc/html/draft-ietf-ppm-dap-taskprov-00#section-3.1-7
mendess
approved these changes
Nov 27, 2024
jhoyla
force-pushed
the
jhoyla/remove-max-batch-size
branch
2 times, most recently
from
80853d8
to
96fc4ee
Compare
jhoyla
force-pushed
the
jhoyla/remove-max-batch-size
branch
from
96fc4ee
to
49da542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft-12 removes
max_batch_sizefrom "fixed-size" batch mode. This PR removesmax_batch_sizefrom the wire format, and sets the value to 0 forLatest, which, per taskprov-00, the last version to featuremax_batch_size, signals that there is nomax_batch_size.This PR also makes
max_batch_sizethe same type,u32, everywhere in the code. The DAP spec doesn't specify a size, so I've take the size fromtaskprov.