Fix broken links in cmd/cloudflared/*.go related to running tunnel as a service
#1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungthuang
reviewed
Apr 2, 2024
update link to the Mac-specific documentation in Mac-specific code Co-authored-by: chungthuang <[email protected]>
|
Hi chungthuang, I've updated the link you mentioned |
chungthuang
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Hi @BWsix thank you for fixing the links to the documentation. Can you rebase on the latest changes and we can merge it?
|
Would be nice to have this merged 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates 3 broken links to document run tunnel as a service.
The one in cmd/cloudflared/updater/update.go can be found by running
cloudflared tunnel run:The other two were found by manually grepping
developers.cloudflare.comin the project.