-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloudflared tunnel ready command #1135
Conversation
Co-authored-by: Julien Laffaye <[email protected]>
@jlaffaye I there anything I can do to fast-track the PR somehow ? |
Am I to understand that the If that is a correct assumption, I would much rather use It at least checks that ready connections are above 0 I've renamed the sub command to |
@firecow That makes sense. 👍🏻 |
A merge of master into your branch may be in order because I was getting an error about "UDP Buffer Sizes" that forced me to merge in master. Which resolved it. But past that this seems to work fine on a quick test. I stood up a separate service at port 8081 to make a cloudflare tunnel with. Then wrote a docker healthcheck into a docker-compose.yml. Which had my local IP there: healthcheck:
test: tunnel --metrics 192.168.0.15:8081 ready || exit 1 Which worked great. The timeout was a little high at 30 seconds but it's fine. |
Master has been merged. |
I'm really waiting for this, as in AWS ECS I can also not get the workaround #1126 working at all. If something breaks our tunnels are currently just hanging. not ideal. |
@DevinCarr or @jcsf One of you guys, wanna give this PR some ❤️ ? |
@chungthuang, @DevinCarr and @jcsf I've synced the fork |
Can anyone push this further along? |
What would be the use case of the old /heathcheck endpoint, if any? |
Is there a docker image for this, while we wait for an official merge? |
@huyz I've just synced the fork. But we need some maintainer or developer to approve the test runs, and eventually merge the change into master. |
Just leaving this here for reference. It seems like the feature is doing what it is supposed to do. |
For a noob, can someone give the exact syntax to put in |
@huyz here's what I use:
|
As this feature is now merged I propose to add the Healthcheck directly into the Dockerfile so that it works automatically and doesn't have to be configured in a docker-compose.yaml file. |
This would make it possible to have a Docker image without wget and curl, and still make docker healthchecking in docker possible
closes #1126