Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-5460 add email_claim_name to cloudflare-go api #1390

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

ajholland
Copy link
Contributor

Description

Adds email_claim_name, which is a recent field we've added that is documented in the API: https://developers.cloudflare.com/api/operations/access-identity-providers-add-an-access-identity-provider

Has your change been tested?

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • [ X] New feature (non-breaking change which adds functionality)

Checklist:

  • [ x] My code follows the code style of this project.
  • [ x] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.
  • [x ] This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1390 (a0c135e) into master (b9ac804) will increase coverage by 0.08%.
Report is 253 commits behind head on master.
The diff coverage is 50.54%.

@@            Coverage Diff             @@
##           master    #1390      +/-   ##
==========================================
+ Coverage   48.33%   48.41%   +0.08%     
==========================================
  Files         133      139       +6     
  Lines       13023    13809     +786     
==========================================
+ Hits         6295     6686     +391     
- Misses       5201     5466     +265     
- Partials     1527     1657     +130     
Files Changed Coverage Δ
access_audit_log.go 79.31% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
access_keys.go 71.42% <ø> (ø)
access_organization.go 53.84% <ø> (ø)
access_service_tokens.go 51.85% <ø> (ø)
account_members.go 65.54% <ø> (ø)
account_roles.go 53.84% <ø> (ø)
accounts.go 50.81% <ø> (ø)
addressing_address_map.go 39.04% <ø> (ø)
addressing_ip_prefix.go 45.45% <ø> (ø)
... and 121 more

... and 1 file with indirect coverage changes

Scopes []string `json:"scopes,omitempty"`
DirectoryID string `json:"directory_id,omitempty"`
EmailAttributeName string `json:"email_attribute_name,omitempty"`
EmailClaimName string `json:"email_claim_name,omitempty"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new field

IdpPublicCert string `json:"idp_public_cert,omitempty"`
IssuerURL string `json:"issuer_url,omitempty"`
OktaAccount string `json:"okta_account,omitempty"`
OktaAuthorizationServerID string `json:"authorization_server_id,omitempty"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new field

@jacobbednarz jacobbednarz merged commit c612c7d into cloudflare:master Sep 8, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.77.0 milestone Sep 8, 2023
github-actions bot pushed a commit that referenced this pull request Sep 8, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.77.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants