Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Read Timeout in Rulesets API #1374

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

iveelsm
Copy link
Contributor

@iveelsm iveelsm commented Aug 25, 2023

Description

Adds support for the usage of the read_timeout field which has been added to the rulesets API. This controls the Proxy Read Timeout for connections to the origin to allow for longer wait times before closing the connection.

Has your change been tested?

The API has been tested thoroughly. Unit tests have been modified to include validation of the API response. Additional testing may be required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

changelog detected ✅

@iveelsm
Copy link
Contributor Author

iveelsm commented Aug 25, 2023

@jacobbednarz copy is currently being made for this on the API side and support for the UI is still in design. This is part of a series of PRs I will be opening both here and in the Terraform repo.

@codecov-commenter
Copy link

Codecov Report

Merging #1374 (cb12b22) into master (b9ac804) will increase coverage by 0.00%.
Report is 200 commits behind head on master.
The diff coverage is 49.62%.

@@           Coverage Diff            @@
##           master    #1374    +/-   ##
========================================
  Coverage   48.33%   48.34%            
========================================
  Files         133      139     +6     
  Lines       13023    13749   +726     
========================================
+ Hits         6295     6647   +352     
- Misses       5201     5453   +252     
- Partials     1527     1649   +122     
Files Changed Coverage Δ
access_audit_log.go 79.31% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
access_keys.go 71.42% <ø> (ø)
access_organization.go 53.84% <ø> (ø)
access_service_tokens.go 51.85% <ø> (ø)
account_members.go 65.54% <ø> (ø)
account_roles.go 53.84% <ø> (ø)
accounts.go 50.81% <ø> (ø)
addressing_address_map.go 39.04% <ø> (ø)
addressing_ip_prefix.go 45.45% <ø> (ø)
... and 121 more

... and 1 file with indirect coverage changes

@jacobbednarz
Copy link
Member

LGTM once the API schemas are present.

(ping me once they are ready and we can hit the big green button)

@jacobbednarz jacobbednarz merged commit c1a3c40 into cloudflare:master Aug 28, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.76.0 milestone Aug 28, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.76.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants