replace encoding/json with github.com/goccy/go-json
#1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1360 +/- ##
==========================================
+ Coverage 48.33% 48.47% +0.14%
==========================================
Files 133 135 +2
Lines 13023 13208 +185
==========================================
+ Hits 6295 6403 +108
- Misses 5201 5253 +52
- Partials 1527 1552 +25
|
jacobbednarz
force-pushed
the
get-off-stdlib-json
branch
from
3a6c2ce
to
d1386d8
Compare
The stdlib has some, ermm, quirks with how certain methods handle strings without a way to customise that behaviour. This bites us in cases where our API payloads (represented as bytes) *shouldn't* be escaping HTML entities however they end up escaped and won't match our internal representation of them. Instead of doing hacky work arounds, I've just swapped out `encoding/json` with `github.com/goccy/go-json` which mentions it is a drop in replacement but, it includes a way to customise certain behaviours as needed.
Ensures the exact cache key will match that which we have stored. Closes #1350
jacobbednarz
force-pushed
the
get-off-stdlib-json
branch
from
d1386d8
to
c4897fb
Compare
|
This functionality has been released in v0.75.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stdlib has some, ermm, quirks with how certain methods handle strings
without a way to customise that behaviour. This bites us in cases where our API
payloads (represented as bytes) shouldn't be escaping HTML entities however
they end up escaped and won't match our internal representation of them.
Instead of doing hacky work arounds, I've just swapped out
encoding/jsonwithgithub.com/goccy/go-jsonwhich mentions it is a drop in replacement but, itincludes a way to customise certain behaviours as needed.
As a side benefit, this will also considerably speed up JSON
marshaling/unmarshaling on larger and more complex payloads.
Closes #1350