-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RawResponse method which returns the standard Response with Result #1355
Conversation
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1355 +/- ##
==========================================
+ Coverage 48.33% 48.50% +0.17%
==========================================
Files 133 136 +3
Lines 13023 13239 +216
==========================================
+ Hits 6295 6422 +127
- Misses 5201 5261 +60
- Partials 1527 1556 +29
|
given |
I'm totally up for that! I just didn't want to break existing APIs. |
for a low level method like this, I think it is fine. just be sure to include a changelog entry and 🚀 |
@jacobbednarz - thanks for the input, I've made those changes. |
This functionality has been released in v0.75.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
We are manually tagging workers using an API that is not yet a part of the Go library (see #1354), but we don't have access to the response's Error, Messages, etc. when using the
Raw()
method, since it just returns the"result"
field. This also returns the Response if applicable (Success
,Errors
, etc.)Description
Simply added a new method that returned
r
instead ofr.Result
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.