fix: invalid -L path for build artifact search #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the 3.x to 4.x update, boring-sys rewrote most of its build script and as a result broke our
own builds. I suspect shenagigans due to nix or our cargo profile.
Inspecting the `OUT_DIR` showed that `OUT_DIR/build/{Release,crypto,ssl}` don't exist, instead all
the artifacts are in `OUT_DIR/build/` directly, so use that in the build script instead.
|
What's the build error? And what version of boringssl are you building with? |
|
The error is |
|
@rushilmehra would it be possible to review this again, please? I haven't tested recently, but I'm pretty sure we still have the issue. Thanks in advance. |
|
Just tested it under 4.12.0 from crates.io and the issue persists. |
|
Considering the patch on our end is now simply: diff --git a/boring-sys/build/main.rs b/boring-sys/build/main.rs
index 86075d3c..3ff818b3 100644
--- a/boring-sys/build/main.rs
+++ b/boring-sys/build/main.rs
@@ -663,6 +663,10 @@ fn main() {
bssl_dir.display(),
build_path
);
+ println!(
+ "cargo:rustc-link-search=native={}/build",
+ bssl_dir.display(),
+ );
}
if config.features.fips_link_precompiled {this should probably be closed and re-opened @rushilmehra, as I have neither the possibility to change the source branch nor close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't managed to link boring for either Linux, windows or macOS without this modification recently, which I find strange
Do you have any idea of what could be happening ?