Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update pull_request_template.md #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions PULL_REQUEST_TEMPLATE/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ Add issue type as a labels
**Component Name:**
<!--- Explain what changes or new features/components are introduced.
eg: A new module/plugin/task/feature.
Note: If you feel, service-version/config-version is not required, specify not required
eg: - [ ] Update Config version (Not required)
-->
- [ ] Add Changelog
- [ ] Update Service version
- [ ] Update Config version
Comment on lines +16 to +18
Copy link

@milap-neupane milap-neupane Sep 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] Add Changelog
- [ ] Update Service version
- [ ] Update Config version
- [ ] 🗄️ I have added the Changelog
- [ ] 📦 I have updated the Service version
- [ ] 🔧 I have updated the Config version
- [ ] ⚡ I have tested performance of lambda api endpoint using Jaeger trace


**Summary/Motivation:**
<!--- Mention the steps carried out to achieve the change along with the motivation (if any). -->
Expand Down