Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBT-763: DBT-764: Upgrading the dbt-core to v1.5.10 and resolving issues #137

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

niteshy
Copy link
Collaborator

@niteshy niteshy commented Mar 28, 2024

Describe your changes

Upgrading dbt-core to 1.5.10 resulted in the following issues:

  1. dbt-core surfaced two weeks ago #9759 when protobuf has released 5.26.0 version which is not compatible with dbt-core. Even though they fixed the issue by pining the version but the backports were NOT done correctly resulting in broken adapters. More details here [Bug] Duplicate dependency specifications means prod and dev version of protobuf might differ dbt-labs/dbt-core#9830. Causing issues MessageToDict() got an unexpected keyword argument 'including_default_value_fields' #135
  2. HiveCredentials extends the dbt-core Credentials class, which is required to implement the unique_field() method. This has caused the issues Implement missing unique_field() in HiveCredentials class #136

Resolve #135, #136

Internal Jira ticket number or external issue link

https://jira.cloudera.com/browse/DBT-763
https://jira.cloudera.com/browse/DBT-764

Testing procedure/screenshots(if appropriate):

Verified the version upgrade and successful run of all tests https://gist.github.com/niteshy/c5adf6d0a195a8e3c7472185f4bfb4c2

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

…ue_field() required for upgrading dbt-core to 1.5.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessageToDict() got an unexpected keyword argument 'including_default_value_fields'
2 participants