rescue if lavinmq starts with faulty msg_store #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorerlingsson
approved these changes
Dec 3, 2024
spuun
approved these changes
Dec 4, 2024
Co-authored-by: Jon Börjesson <[email protected]>
Co-authored-by: Jon Börjesson <[email protected]>
carlhoerberg
reviewed
Dec 4, 2024
Comment on lines
350
to
351
| rescue ex | ||
| @log.error { "Closing message store: invalid SchemaVersion in #{path}" } |
There was a problem hiding this comment.
how do we know that it is a "invalid SchemaVersion" error if we catch all errors? aren't we raising a specific exception then? Catch only that then, or log ex.message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
today if we get an error when initialising the message store in
load_segments_from_diskandload_stats_from_segmentswe will raise an exception and LavinMQ will not be able to start. With these changes we will instead just close the queue and let LavinMQ start up with closed queues.HOW can this pull request be tested?
try to start up with a faulty msg_store.