Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yield on delete so lavinmq doesnt freeze during delete #859

Merged
merged 1 commit into from
Nov 22, 2024
Merged

yield on delete so lavinmq doesnt freeze during delete #859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/lavinmq/amqp/queue/message_store.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,17 @@ module LavinMQ

def delete
close
@segments.each_value { |f| @replicator.try &.delete_file(f.path); f.delete }
@acks.each_value { |f| @replicator.try &.delete_file(f.path); f.delete }
@segments.each_value { |f| delete_file(f) }
@acks.each_value { |f| delete_file(f) }
FileUtils.rm_rf @queue_data_dir
end

def delete_file(file)
@replicator.try &.delete_file(file.path)
file.delete(raise_on_missing: false)
Fiber.yield
end

def empty?
@size.zero?
end
Expand Down
Loading