Dont raise NotFoundError when deleting file

[spuun]

WHAT is this pull request doing?

I see no point in raising FileNotFound when trying to delete a file.

One way of triggering the exception:

1. Publish a bunch of messages to a queue to get some segment files
2. Start a consumer on that queue
3. Remove some segments while the consumer is running
4. Disconnect the consumer
5. Purge queue

HOW can this pull request be tested?

See steps above.

[snichme]

Or can we monkey patch stdlid with a delete! or something that delete if exists otherwise just return.
Just see some repetition here

[spuun]

Or can we monkey patch stdlid with a delete! or something that delete if exists otherwise just return. Just see some repetition here

True. It's MFiles in this case, so I can just add a method to it.

[spuun]

That will actaully be much better. Rescuing like I'm doing now means that #close won't be called.

[spuun]

Did another take. I think this is better.

[snichme]

Enlighten me: We go from libc.unlink to File.delete are they the same?

[spuun]

File.delete (public API) is using Crystal::System::File.delete (non-public API) which will use platform dependent calls. On unix it will be LibC.unlink. Now MFile doesn't work on anything else than *nix, but I think it's nice to use public APIs.

[spuun]

https://github.com/crystal-lang/crystal/blob/master/src/file.cr#L427
and
https://github.com/crystal-lang/crystal/blob/master/src/crystal/system/unix/file.cr#L131-L140

[snichme]

aha ok, thanks for the explanation