Longer lease TTL and run lease_keepalive earlier #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snichme
approved these changes
Nov 18, 2024
viktorerlingsson
changed the title
viktorerlingsson
force-pushed
the
etcd-lease-keepalive-earlier
branch
from
a3576ce to
be81e74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen the etcd lease expiring without obvious reasons, but probably because LavinMQ was busy doing something else during the pretty short timeframe (0.5s) it has to run
lease_keepalive.WHAT is this pull request doing?
Increases default lease TTL 5s -> 10s. Also timeouts earlier so
lease_keepalivehas a longer window to run (3s instead of 0.5s), which should make it less likely that unnecessary leader elections happen.HOW can this pull request be tested?
manual/specs