Code Clean Up for Platfrom Controller #1375
Conversation
| break | ||
| } | ||
| _, err := c.platformStackclientset.WorkflowsV1alpha1().ResourceCompositions(namespace).Update(context.Background(), fooCopy, metav1.UpdateOptions{}) | ||
| //_, err := c.sampleclientset.MoodlecontrollerV1().Moodles(foo.Namespace).Update(fooCopy) |
There was a problem hiding this comment.
We can remove this commented out line.
| @@ -566,15 +566,15 @@ func createResourcePolicy(resPolicySpec interface{}, namespace string) { | |||
| } | |||
| } | |||
|
|
|||
| func deleteResourcePolicy(resPolicySpec interface{}, namespace string) { | |||
| func deleteResourcePolicy(resPolicySpec interface{}, namespace string) { | |||
| fmt.Println("Inside deleteResourcePolicy.") | |||
| resPolicyObject := resPolicySpec.(platformworkflowv1alpha1.ResourcePolicy) | |||
| inputResPolicyName := resPolicyObject.ObjectMeta.Name | |||
| /*namespace := resPolicyObject.ObjectMeta.Namespace | |||
There was a problem hiding this comment.
We can delete these commented out lines as well.
| /* _, err1 := crdClient.CustomResourceDefinitions().Create(context.Background(), crd, metav1.CreateOptions{}) | ||
| if err1 != nil { | ||
| panic(err1.Error()) | ||
| /* _, err1 := crdClient.CustomResourceDefinitions().Create(context.Background(), crd, metav1.CreateOptions{}) |
There was a problem hiding this comment.
We can delete these commented out lines (732-736).
|
@SuyogShinde942 Mostly looks good. There are some commented lines that we can delete as well. |
|
I have removed the commented and some debugging code |
platform-operator/main.go
Outdated
| @@ -58,10 +57,10 @@ func main() { | |||
| }() | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
We can also remove the comment strings (/* */)
| @@ -603,57 +594,50 @@ func deleteResourcePolicy(resPolicySpec interface{}, namespace string) { | |||
|
|
|||
| func flatten(yaml_contents map[string]interface{}, types_dict map[string]apiextensionsv1beta1.JSONSchemaProps) map[string]apiextensionsv1beta1.JSONSchemaProps { | |||
There was a problem hiding this comment.
Can you verify if flatten method is being referred to anywhere?
If not, we can delete it.
There was a problem hiding this comment.
We are using it in the getChartValueTypes function
There was a problem hiding this comment.
But getChartValueTypes() is part of the commented out code that you have removed.
So I think we can safely remove flatten().
|
@SuyogShinde942 I have added some more comments. |
|
|
||
| types_dict[key] = jsonSchemaInner | ||
| } | ||
|
|
||
| } | ||
| //fmt.Println(types_dict) | ||
| return types_dict | ||
| } | ||
|
|
||
| func getChartValueTypes(data []byte) map[string]apiextensionsv1beta1.JSONSchemaProps { |
There was a problem hiding this comment.
I think we can get rid of this method as well.
|
@SuyogShinde942 I have added couple of more comments. |
SuyogShinde942
force-pushed
the
master
branch
from
1d1740c
to
694b58a
Compare
This PR resolves issues #1371 and #1370:
Cleanup Unused Resource Policy Controller (#1371):
Removed the unused resourcepolicycontroller.go file.
Deleted commented-out references to resourcepolicycontroller in main.go, as it was never utilized.
Enhancements in Resource Composition Handling (#1370):
Improved PlatformController by ensuring the handleCRD method registers the CRD defined in the ResourceComposition spec.