Perf #5
Merged
Perf #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Halves syntime benchmark:
TOTAL COUNT
BEFORE: 0.116939 49694
AFTER: 0.052234 27016
These are valid symbol characters.
$ syntime clj/src/vim_clojure_static/generate.clj Before: TOTAL COUNT MATCH SLOWEST AVERAGE NAME PATTERN 0.031679 2003 1906 0.000092 0.000016 clojureSymbol \v%([a-zA-Z!$&*_+=|<.>?-]|[^\x00-\x7F])+%(:?%([a-zA-Z0-9!#$%&*_+=|'<.>/?-]|[^\x00-\x7F]))*[#:]@<! 0.051484 27016 After: TOTAL COUNT MATCH SLOWEST AVERAGE NAME PATTERN 0.010608 2003 1906 0.000030 0.000005 clojureSymbol \v%([a-zA-Z!$&*_+=|<.>?-]|[^\x00-\x7F])+%(:?%([a-zA-Z0-9!#$%&*_+=|'<.>/?-]|[^\x00-\x7F]))*[#:]@1<! 0.030519 27016 $ curl -LO https://raw.githubusercontent.com/http-kit/http-kit/master/src/org/httpkit/client.clj $ syntime client.clj Before: TOTAL COUNT MATCH SLOWEST AVERAGE NAME PATTERN 0.029451 2340 2293 0.000079 0.000013 clojureSymbol \v%([a-zA-Z!$&*_+=|<.>?-]|[^\x00-\x7F])+%(:?%([a-zA-Z0-9!#$%&*_+=|'<.>/?-]|[^\x00-\x7F]))*[#:]@<! 0.046375 23668 After: TOTAL COUNT MATCH SLOWEST AVERAGE NAME PATTERN 0.010855 2340 2293 0.000031 0.000005 clojureSymbol \v%([a-zA-Z!$&*_+=|<.>?-]|[^\x00-\x7F])+%(:?%([a-zA-Z0-9!#$%&*_+=|'<.>/?-]|[^\x00-\x7F]))*[#:]@1<! 0.027972 23668 Thanks to Richard Hull (@rm-hull).
Reduces number syntax matching time by 65%
|
Merging this so this gets more testing, I think I've been running this branch for a long time. |
axvr
added
performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From guns/vim-clojure-static#77
0.071553 sec and 49171 calls for master.
0.018733 sec and 20428 calls for this branch.
Indent performance report in #6
I've been using this for two days and haven't noticed regressions.