Modernizing Project #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere interrupted without properly exiting the idle animation
… now all correctly end idle animations.
…he queue wasn't empty.
|
Nice. I hope this gets merged. |
|
+1 |
Example:
agent.speak('Hello I <em class="cool">support HTML tags!');
|
+1 |
1 similar comment
|
+1 |
Lots of improvements
|
Awesome! Why isn't this PR still not merged into the master after almost 3 years? |
|
My guess is that the original authors don't have the time to manage this project. |
|
Does that still make it "modern" however? |
Nope. NPM is preferred over gulp I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding third-party patches and assembling package through Gulp.