Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of netconf notification #565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpereh
Copy link
Contributor

@mpereh mpereh commented Oct 15, 2024

No description provided.

Copy link
Member

@olofhagsand olofhagsand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it could be useful to have a knob for turning off netconf notifications.
But I am interested in the usecase, in which way did it fail / why was it necessary?
But there are other ways to design the knob, and this is knob is not right: CLICON_NETCONF_NOTIFICATION_CAP is not defined in clixon-config.yang.
If it is not defined there (and added to the config file) then this will(should) result in a sanity check error when loading the config.
There are also other ways, such as compile time using clixon_custom.h, or make a --enable / --with rule in configure.ac.
One could also define it as a FEATURE possibly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants