Added checks for scripts stuck in dead loop. #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x87
reviewed
Dec 2, 2024
| @@ -43,6 +49,7 @@ class DebugUtils | |||
| } | |||
|
|
|||
| auto config = GetConfigFilename(); | |||
| configLimitCommand = GetPrivateProfileInt("Limits", "Command", 100000, config.c_str()); | |||
There was a problem hiding this comment.
Excluded legacy scripts and restored restriction to 100000.
x87
reviewed
Dec 2, 2024
|
|
||
| ; limits between 'wait' command in script after which it is considered hanging | ||
| [Limits] | ||
| command = 200000 |
MiranDMC
force-pushed
the
dead_loop_prevention
branch
from
a5fa19c to
510dd73
Compare
x87
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
200k was enough for example script, but let's not create something that lags