Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NHibernate.SqlAzure 2.1.6 #20296

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Conversation

clearlydefinedbot
Copy link
Contributor

Type: Missing

Summary:
NHibernate.SqlAzure 2.1.6

Details:
Add MIT License

Resolution:
License Url:
https://github.com/MRCollective/NHibernate.SqlAzure/blob/master/LICENSE

Description:
Info provided from main github repository

Pull request generated by Microsoft tooling.

Affected definitions:

@clearlydefinedbot
Copy link
Contributor Author

You can review the change introduced to the full definition at ClearlyDefined.

@capfei
Copy link
Member

capfei commented Jun 24, 2022

@AE49 @ariel11 I think this should be Apache-2.0. The license says that there is a version with and a version without Microsoft Transient Fault Handling library. Looking at the license, the standalone version is MIT but the bundled version uses their license.
https://web.archive.org/web/20170326124620/http://entlib.codeplex.com/license

What do you think?

@capfei capfei added the feedback requested Unclear curation. PRs with this label will be closed after 60 days if no activity. label Jun 24, 2022
@capfei capfei self-assigned this Jun 24, 2022
@AE49
Copy link
Contributor

AE49 commented Jun 27, 2022

@capfei @ariel11 I'm thinking "MIT OR Apache-2.0" to cover both versions of the package.

@capfei
Copy link
Member

capfei commented Jun 29, 2022

The version without is a separate package: NHibernate.SqlAzure.Standalone.
https://www.nuget.org/packages/NHibernate.SqlAzure.Standalone

@capfei
Copy link
Member

capfei commented Jun 30, 2022

Discussed on call and opened an issue with the authors for clarification.
MRCollective/NHibernate.SqlAzure#39

@capfei capfei added researching Issue with multiple versions and removed feedback requested Unclear curation. PRs with this label will be closed after 60 days if no activity. labels Jun 30, 2022
@capfei capfei removed the researching Issue with multiple versions label Aug 3, 2022
@capfei capfei merged commit 93d4447 into master Aug 3, 2022
@capfei capfei deleted the clearlydefinedbot_220623_225354.235 branch August 3, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants