Rework how curl errors are checked #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where curl perform returns an error but is actually a 400 level response, swupd needs to check curl info to see this. If the info reveals a 400 level response, return the corresponding download status error to prevent useless download retries. Signed-off-by: William Douglas <[email protected]>
Signed-off-by: William Douglas <[email protected]>
bryteise
force-pushed
the
handle-400-perform-fails
branch
from
25cff6f to
4e53cc2
Compare
bwarden
approved these changes
Apr 4, 2024
| @@ -456,6 +456,23 @@ enum download_status process_curl_error_codes(int curl_ret, CURL *curl_handle) | |||
| return DOWNLOAD_STATUS_ERROR; | |||
| } | |||
| } else { /* download failed but let our caller do it */ | |||
| long response = 0; | |||
| curl_easy_getinfo(curl_handle, CURLINFO_RESPONSE_CODE, &response); | |||
There was a problem hiding this comment.
Fine for now, but when we refactor, we should move this call before this if/else and figure out how to condense these conditions better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where curl perform returns an error but is actually a 400 level response, swupd needs to check curl info to see this. If the info reveals a 400 level response, return the corresponding download status error to prevent useless download retries.