Avoid printing optimization level error repeatedly

The error message about skipping unsupported file optimization levels only needs to be printed once so do that instead of potentially spamming it. Signed-off-by: William Douglas <[email protected]>
clearlinux · Jan 22, 2024 · 3d8634e · 3d8634e
1 parent 5ebfce0
commit 3d8634e
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/swupd_lib/manifest_parser.c b/src/swupd_lib/manifest_parser.c
@@ -218,6 +218,7 @@ struct manifest *manifest_parse(const char *component, const char *filename, boo
 	struct list *optional = NULL;
 	unsigned long long filecount = 0;
 	unsigned long long contentsize = 0;
+	static bool bad_opt_warned = false;
 
 	infile = fopen(filename, "rbm");
 	if (infile == NULL) {
@@ -377,7 +378,10 @@ struct manifest *manifest_parse(const char *component, const char *filename, boo
 
 		bitmask_translation = OPTIMIZED_BITMASKS[(unsigned char)line[2]];
 		if (bitmask_translation > APX_7) {
-			error("Skipping unsupported file optimization level\n");
+			if (!bad_opt_warned) {
+				bad_opt_warned = true;
+				error("Skipping unsupported file optimization level\n");
+			}
 			FREE(file);
 			continue;
 		}