Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eslint/prettier with biome #10

Merged
merged 36 commits into from
Aug 2, 2024
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
07f890e
Remove eslint and prettier
sverhoeven Aug 1, 2024
b203b86
Move biome to now
sverhoeven Aug 1, 2024
17615d9
pnpm add --save-dev --save-exact --workspace-root @biomejs/biome
sverhoeven Aug 1, 2024
9f976b9
pnpm biome init
sverhoeven Aug 1, 2024
b49140e
Suggest biome vs code extension
sverhoeven Aug 1, 2024
9d035c8
Add format-and-lint script
sverhoeven Aug 1, 2024
a748097
Enable formatter
sverhoeven Aug 1, 2024
797932e
Add biome to CI
sverhoeven Aug 1, 2024
db93a82
Ignore solidstart build files
sverhoeven Aug 1, 2024
aa780d2
Enable vcs
sverhoeven Aug 1, 2024
76db05d
Move biome commands to own chapter
sverhoeven Aug 1, 2024
642f055
Format
sverhoeven Aug 1, 2024
cd523c1
Fix lint errors
sverhoeven Aug 1, 2024
27f024f
Sort imports
sverhoeven Aug 1, 2024
3c536f9
Fix lint errors with unsafe fixes
sverhoeven Aug 1, 2024
59425b1
Dont run workflow twice
sverhoeven Aug 1, 2024
1b52800
Use github reporter + only one running workflow
sverhoeven Aug 1, 2024
66b222b
Use space for indent
sverhoeven Aug 2, 2024
28a7d91
npx needs node
sverhoeven Aug 2, 2024
0c8f3a7
Added typecheck
sverhoeven Aug 2, 2024
38efb9a
Ignore most remaining biome errors
sverhoeven Aug 2, 2024
e63a720
Badges for github and quality ci workflow
sverhoeven Aug 2, 2024
05db998
Sort tailwind classes
sverhoeven Aug 2, 2024
df85da6
Merge remote-tracking branch 'origin/main' into biome
sverhoeven Aug 2, 2024
01171c0
Move typecheck to linter chapter
sverhoeven Aug 2, 2024
639e349
Auto-sort imports on save in vscode
Peter9192 Aug 2, 2024
d328c3b
Format settings
Peter9192 Aug 2, 2024
f870961
Merge remote-tracking branch 'origin/main' into biome
sverhoeven Aug 2, 2024
cafdd7f
Merge remote-tracking branch 'origin/main' into biome
sverhoeven Aug 2, 2024
a03154b
format-and-lint:fix
sverhoeven Aug 2, 2024
7d1a14e
fix typecheck
sverhoeven Aug 2, 2024
a61b3c2
Use biome from package.json
sverhoeven Aug 2, 2024
640dcde
Add lint errors to test ci reporting
sverhoeven Aug 2, 2024
98a8576
Enable github reporter again
sverhoeven Aug 2, 2024
3ea691e
Revert "Add lint errors to test ci reporting"
sverhoeven Aug 2, 2024
f69234d
Remove root tasks for biome
sverhoeven Aug 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add biome to CI
  • Loading branch information
sverhoeven committed Aug 1, 2024
commit 797932e17f371f3a69d9fecbe294560e1da961c6
18 changes: 18 additions & 0 deletions .github/workflows/quality.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Code quality

on:
push:
pull_request:

jobs:
quality:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup Biome
uses: biomejs/setup-biome@v2
with:
version: latest
- name: Run Biome
run: biome ci .